Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make update-fips-checksums to release.sh script #15271

Closed
wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented May 13, 2021

Fixes #15223

@t8m t8m added approval: review pending This pull request needs review by a committer branch: master Merge to master branch labels May 13, 2021

make update >&42

make update-fips-checksums >&42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the plan here is that we have the checksums updated only for each release..
Is there a way of displaying all the differences between master and the release checksums currently? Or is this a manual process?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a diff-fips-checksums Makefile target

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 14, 2021
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label May 15, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label May 15, 2021
@paulidale
Copy link
Contributor

Merged to master.

@paulidale paulidale closed this May 15, 2021
openssl-machine pushed a commit that referenced this pull request May 15, 2021
Fixes #15223

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #15271)
devnexen pushed a commit to devnexen/openssl that referenced this pull request Jul 7, 2021
Fixes openssl#15223

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#15271)
@t8m t8m deleted the fips-checksums-release branch May 11, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update fips checksums only before release and have a CI job to flag PRs that touch fips sources
5 participants