X509_digest_sig: Handle RSA-PSS and EDDSA certificates #15618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identify digest from sigalg params for RSA-PSS and fallback to SHA-256 for EDDSA. Fixes openssl#15477
mattcaswell
requested changes
Jun 4, 2021
|
fixup pushed |
t8m
added
approval: review pending
DDvO
requested changes
Jun 4, 2021
DDvO
added
approval: done
|
Sorry, I forgot to set the "approval:done". Can this still be merged now? |
|
We can wait a day. There is no hurry. |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
t8m
added
approval: ready to merge
|
Merged to master. Thank you for the reviews. |
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
Identify digest from sigalg params for RSA-PSS and fallback to SHA-256 for EDDSA. Fixes openssl#15477 Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com> (Merged from openssl#15618)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify digest from sigalg params for RSA-PSS and fallback
to SHA-256 for EDDSA.
Fixes #15477
Checklist