TEST: Display the correct shared library name #15776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In test/recipes/01-test_symbol_presence.t
levitte
added
branch: master
mattcaswell
previously approved these changes
Jun 15, 2021
mattcaswell
added
approval: done
|
Please note that MacOS build regressed due to the earlier test/recipes/01-test_symbol_presence.t fix. |
|
Should we just skip this test on macos? Its a developer thing really |
It renames symbols, so we can a false negative
I pushed an extra commit that does exactly that |
levitte
added
the
severity: urgent
|
Because of the regression, I made this urgent |
levitte
added
approval: review pending
mattcaswell
approved these changes
Jun 15, 2021
mattcaswell
added
approval: done
paulidale
approved these changes
Jun 15, 2021
|
Merged to master. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 15, 2021
In test/recipes/01-test_symbol_presence.t Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #15776)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 15, 2021
It renames symbols, so we can a false negative Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #15776)
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
In test/recipes/01-test_symbol_presence.t Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#15776)
devnexen
pushed a commit
to devnexen/openssl
that referenced
this pull request
Jul 7, 2021
It renames symbols, so we can a false negative Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#15776)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test/recipes/01-test_symbol_presence.t