Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing session timeout calc (fixes #16142) #16145

Closed
wants to merge 1 commit into from
Closed

Add missing session timeout calc (fixes #16142) #16145

wants to merge 1 commit into from

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jul 23, 2021 •
edited

Add missing session timeout calculation in ssl_get_new_session()

Fixes #16142

Checklist
  • documentation is added or updated
  • tests are added or updated

@t8m t8m added approval: review pending This pull request needs review by a committer branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug labels Jul 23, 2021
@t8m
Copy link
Member

t8m commented Jul 23, 2021

It's better to put the Fixes #16142 into a separate line in the commit message body. If you could amend the message, please. (Approved from me with or without the commit message change.)

@tmshort
Add missing session timeout calc
b2ec266 
Fixes openssl#16142

Add missing session timeout calculation in `ssl_get_new_session()`
@tmshort
Copy link
Contributor Author

tmshort commented Jul 23, 2021

github seems to recognize it either way... but done...

@tmshort tmshort mentioned this pull request Jul 23, 2021
Closed
@tmshort
Copy link
Contributor Author

tmshort commented Jul 25, 2021

Good to go?

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 26, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 27, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jul 28, 2021
@tmshort @paulidale
Add missing session timeout calc
a65c8d8 
Fixes #16142

Add missing session timeout calculation in `ssl_get_new_session()`

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #16145)
@paulidale
Copy link
Contributor

Merged, thanks for this fix.

@paulidale paulidale closed this Jul 28, 2021
@tmshort tmshort deleted the fix-16142 branch September 20, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSL Session cache timeout from context is ignored
4 participants
@tmshort @t8m @openssl-machine @paulidale