Add NPN to an SSL3 build #1629
Closed
Add NPN to an SSL3 build #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @ekasper :) |
ekasper
suggested changes
Oct 6, 2016
| @@ -45,7 +45,7 @@ matrix: | |||
| env: CONFIG_OPTS="enable-msan" | |||
| - os: linux | |||
| compiler: clang-3.6 | |||
| env: CONFIG_OPTS="no-asm enable-ubsan enable-rc5 enable-md2 enable-ssl3 enable-ssl3-method -fno-sanitize=alignment" | |||
| env: CONFIG_OPTS="no-asm enable-ubsan enable-rc5 enable-md2 enable-ssl3 enable-ssl3-method enable-nextprotoneg -fno-sanitize=alignment" | |||
There was a problem hiding this comment.
Can you please also enable it on the COVERALLS target above?
There was a problem hiding this comment.
somehow i missed your comment. added your request.
ekasper
approved these changes
Oct 24, 2016
levitte
pushed a commit
that referenced
this pull request
Oct 24, 2016
Reviewed-by: Emilia Käsper <emilia@openssl.org> (Merged from #1629)
|
thanks! commit 211bf9f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.