X509 v2i_AUTHORITY_KEYID(): Improve error reporting on parsing config values/options
#16345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DDvO
added
the
approval: otc review pending
t8m
added
branch: master
|
IMO this is a feature unfortunately so it cannot be merged to 3.0 without an exception. |
No urgency from my perspective. So I've marked it post 3.0.0 |
Can we continue with this now? |
DDvO
force-pushed
the
improve_v2i_AUTHORITY_KEYID_parsing
branch
from
338b577
to
11ded7f
Compare
|
Rebased this PR to fix a doc merge conflict. |
paulidale
approved these changes
Jan 6, 2022
paulidale
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Jan 7, 2022
…es/options Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #16345)
|
Merged - thanks @paulidale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A further spin-off if #16300:
complete configuration parsing for AKID extensions and respective error reporting in
v2i_AUTHORITY_KEYID().