Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation referring to 'function code' #16353

Closed

Conversation

omajid
Copy link
Contributor

@omajid omajid commented Aug 18, 2021

ERR_GET_FUNC was removed, so remove references to 'function code' as well from docs.

This was somehow missed from https://github.com/openssl/openssl/pull/16004/files#diff-fe4a27fe0bdafa6ed60d5d12600db394dab647b01e9f03a609b3a098043b7a74

CLA: trivial

Checklist
  • documentation is added or updated

ERR_GET_FUNC was removed, so remove references to 'function code' as
well from docs.

CLA: trivial
@beldmit
Copy link
Member

beldmit commented Aug 18, 2021

I agree it is trivial.

@beldmit beldmit added approval: review pending This pull request needs review by a committer branch: master Merge to master branch labels Aug 18, 2021
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this being trivial.

@paulidale paulidale added the triaged: documentation The issue/pr deals with documentation (errors) label Aug 18, 2021
@paulidale
Copy link
Contributor

@beldmit was that meant to be an approval?

Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial enough

Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 19, 2021
@paulidale paulidale added the cla: trivial One of the commits is marked as 'CLA: trivial' label Aug 19, 2021
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

openssl-machine pushed a commit that referenced this pull request Aug 20, 2021
ERR_GET_FUNC was removed, so remove references to 'function code' as
well from docs.

CLA: trivial

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #16353)
@beldmit
Copy link
Member

beldmit commented Aug 20, 2021

Merged. Thanks for your contribution!

@beldmit beldmit closed this Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants