Minor cleanups #16362
Closed
Minor cleanups #16362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different tests may use unexpectedly different versions of perl, depending on whether they hardcode the path to the perl executable or if they resolve the path from the environment. This fixes it so that the same perl is always used. CLA: trivial
levitte
reviewed
Aug 19, 2021
levitte
reviewed
Aug 19, 2021
richsalz
reviewed
Aug 19, 2021
config
Outdated
| @@ -6,5 +6,5 @@ | |||
| # in the file LICENSE in the source distribution or at | |||
| # https://www.openssl.org/source/license.html | |||
|
|
|||
| THERE=`dirname $0` | |||
| THERE=$(dirname $0) | |||
There was a problem hiding this comment.
Interesting question whether this should be done, or the greater portabality of backtick should be preserved.
There was a problem hiding this comment.
Solaris 10 default shell might have an issue with `...` vs $(...) but I have no way of testing that.
richsalz
reviewed
Aug 19, 2021
util/find-unused-errs
Outdated
| @@ -36,16 +36,16 @@ cd include/openssl || exit 1 | |||
| grep "$PAT" * | grep -v ERR_FATAL_ERROR | awk '{print $3;}' | sort -u >$X1 | |||
| cd ../.. | |||
|
|
|||
| for F in `cat $X1` ; do | |||
| for F in $(cat $X1) ; do | |||
There was a problem hiding this comment.
Same portability comment. I prefer to keep the backticks.
On the other hand, a case could be made to just remove this file.
There was a problem hiding this comment.
I agree with removal of files from the repository, if they are of no use anymore.
|
Congrats on the hashbang perl fixes! |
CLA: trivial
CLA: trivial
t8m
added
approval: otc review pending
|
Please drop the shellcheck fix commit and I'll approve the PR. |
|
Rebased without the shellcheck fixes. |
t8m
approved these changes
Aug 24, 2021
|
I agree with CLA: trivial. |
t8m
added
approval: review pending
paulidale
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Sep 2, 2021
Different tests may use unexpectedly different versions of perl, depending on whether they hardcode the path to the perl executable or if they resolve the path from the environment. This fixes it so that the same perl is always used. Fix some trailing whitespace and spelling mistakes as well. CLA: trivial Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #16362)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 2, 2021
Different tests may use unexpectedly different versions of perl, depending on whether they hardcode the path to the perl executable or if they resolve the path from the environment. This fixes it so that the same perl is always used. Fix some trailing whitespace and spelling mistakes as well. CLA: trivial Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #16362) (cherry picked from commit 473664a)
|
Merged to master and 3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial spelling, whitespace, hashbang, and codestyle fixes.