Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: move final two run-checker CIs to GitHub Actions #16438

Closed
wants to merge 3 commits into from

Conversation

paulidale
Copy link
Contributor

The final pair are fuzzing builds which were left behind.

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale self-assigned this Aug 27, 2021
@paulidale paulidale force-pushed the ci-fuzz branch 14 times, most recently from fa619bf to 2768a6a Compare August 27, 2021 03:46
paulidale added a commit to paulidale/tools that referenced this pull request Aug 27, 2021
Not to be merged until after openssl/openssl#16438 is merged and working.
@paulidale
Copy link
Contributor Author

paulidale commented Aug 27, 2021

This requires the changes from #16433 before the CIs will pass.
Amongst other things.

@paulidale
Copy link
Contributor Author

The follow on question is should we drop run-checker entirely.
That's a separate PR however.

@paulidale paulidale marked this pull request as ready for review August 31, 2021 22:56
@paulidale paulidale added approval: review pending This pull request needs review by a committer branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch labels Aug 31, 2021
@t8m
Copy link
Member

t8m commented Sep 1, 2021

I suppose this will be push-only CI.

@levitte
Copy link
Member

levitte commented Sep 1, 2021

The follow on question is should we drop run-checker entirely.
That's a separate PR however.

Not to mention sysadmin action

@paulidale
Copy link
Contributor Author

I've no problem with this being push only. The builds aren't onerous, so I didn't think it was important.

@paulidale
Copy link
Contributor Author

Switched to push only.

Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. As you said elsewhere, we should review the list of CI builds we do at some point.

@paulidale paulidale added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: review pending This pull request needs review by a committer labels Sep 2, 2021
openssl-machine pushed a commit that referenced this pull request Sep 2, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #16438)
openssl-machine pushed a commit that referenced this pull request Sep 2, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #16438)

(cherry picked from commit f92bfdd)
@paulidale
Copy link
Contributor Author

Merged, thanks.

@paulidale paulidale closed this Sep 2, 2021
@paulidale paulidale deleted the ci-fuzz branch September 2, 2021 09:24
openssl-machine pushed a commit to openssl/tools that referenced this pull request Sep 2, 2021
Not to be merged until after openssl/openssl#16438 is merged and working.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants