New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APPS/{x509,req}: Fix description and diagnostics of -key, -in, etc. options #16440
Conversation
OTC: not blocking 3.0.0 release. OTC will decide later if this is acceptable for 3.0 branch. |
This pull request is ready to merge |
Can one meanwhile merge to master again as usual? |
Yes, you can merge to master. We're still a while from determining futures though but a change like this seems reasonable to include now. |
…ptions Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #16440)
…y option Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #16440)
Merged - thanks @paulidale |
Is it already clear if/how to potentially (back-)port this to 3.0? |
It is not a pure documentation fix. It would be probably better to open a new PR against 3.0 branch if you want OTC to consider this. |
I've flagged this for OTC discussion with respects to merging all of this or just the documentation changes to the 3.0 branch. |
Over the years, the
x509
andreq
app options have become a messand their documentation and help output is partly outdated, incomplete, or even wrong.
I recently came across this issue again when extending the tests in #16342.
This PR improves the description of the
-key
,-in
, and related optionsand adds some warnings for useless or problematic option combinations.
Note that this does not change the semantics of the options.
It would be good to make them more consistent or at least flag some combinations as error,
but we likely cannot do this before the 3.0 release.