New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APPS load_key_certs_crls()
: Make file access errors much more readable
#16452
Conversation
Doing the latter improvement in |
I have to disagree that your way is less ugly. 😁 |
IMO this is not something that should be merged before 3.0 release. |
Why? It takes much less code than adding a wrapper function and making the various print function calls explicitly dependent on an explicit |
I advocate for merging this before the release because it corrects issues introduced with OSSL_STORE in 3.0. |
This reverts part of commit ef04491 using a less invasive suppression.
50ab00e
to
6756f5e
Compare
Also handling of this PR should be resumed, since we are after the 3.0 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one style nit.
Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #16452)
Merged - thanks @paulidale |
Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#16452) (cherry picked from commit 7c64ca7)
This reverts part of commit ef04491 using a less invasive suppression. Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#16452) (cherry picked from commit 6e24994)
Since the use of OSSL_STORE for file loading in apps, the output in case of file access errors has become needlessly bulky and hard to read, for instance:
It turns out that the first error queue entry is spurious, so this PR prunes it.
The second entry is quite informative, but not nice to read for app users,
so I've made sure that the
errno
string is printed directly instead.This way, the output on the above app invocation becomes