Enhance the srctop, bldtop, data and result functions to check the result #16523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
added
branch: master
|
This will stop failing as soon as #16518 has been merged into master |
levitte
force-pushed
the
enhance-OpenSSL.Test-file-and-directory-functions
branch
from
104cbf2
to
ca8aa2b
Compare
|
#16532 will be needed as well for this PR to stop failing |
paulidale
approved these changes
Sep 8, 2021
paulidale
added
approval: done
…sult This affects bldtop_dir, bldtop_file, srctop_dir, srctop_file, data_dir, data_file, result_dir, and result_file. They are all enhanced to check that the resulting path really is a directory or a file. They only do this if the path exists. This allows the tests to catch if these functions are used incorrectly, even on systems where the syntax for directories and files is the same.
levitte
force-pushed
the
enhance-OpenSSL.Test-file-and-directory-functions
branch
from
ca8aa2b
to
f250c6d
Compare
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 9, 2021
…sult This affects bldtop_dir, bldtop_file, srctop_dir, srctop_file, data_dir, data_file, result_dir, and result_file. They are all enhanced to check that the resulting path really is a directory or a file. They only do this if the path exists. This allows the tests to catch if these functions are used incorrectly, even on systems where the syntax for directories and files is the same. Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #16523)
|
Merged 2fe2279 Enhance the srctop, bldtop, data and result functions to check the result |
levitte
deleted the
enhance-OpenSSL.Test-file-and-directory-functions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects bldtop_dir, bldtop_file, srctop_dir, srctop_file,
data_dir, data_file, result_dir, and result_file. They are all
enhanced to check that the resulting path really is a directory or a
file. They only do this if the path exists.
This allows the tests to catch if these functions are used
incorrectly, even on systems where the syntax for directories and
files is the same.