Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the example SSH KDF code. #16550

Closed
wants to merge 1 commit into from
Closed

Fix the example SSH KDF code. #16550

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

A salt was being set instead of a session ID.

Fixes #16525

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch labels Sep 7, 2021
@paulidale paulidale self-assigned this Sep 7, 2021
@paulidale
Fix the example SSH KDF code.
5c30015 
A salt was being set instead of a session ID.

Fixes openssl#16525
t8m
t8m approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for both master and 3.0.

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 8, 2021
openssl-machine pushed a commit that referenced this pull request Sep 9, 2021
@paulidale
Fix the example SSH KDF code.
8128013 
A salt was being set instead of a session ID.

Fixes #16525

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #16550)
openssl-machine pushed a commit that referenced this pull request Sep 9, 2021
@paulidale
Fix the example SSH KDF code.
c076f7b 
A salt was being set instead of a session ID.

Fixes #16525

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #16550)

(cherry picked from commit 8128013)
@paulidale
Copy link
Contributor Author

Merged to 3.0 and master. Thanks for the review.

@paulidale paulidale closed this Sep 9, 2021
@paulidale paulidale deleted the sshkdf-doc branch May 6, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

Assignees

@paulidale paulidale

Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVP_KDF-SSHKDF example uses OSSL_KDF_PARAM_SALT instead of OSSL_KDF_PARAM_SSHKDF_SESSION_ID
2 participants
@paulidale @t8m