Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'openssl speed' information printout #16563

Closed
wants to merge 1 commit into from
Closed

Fix 'openssl speed' information printout #16563

wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Sep 8, 2021

Most of all, this reduces the following:

built on: built on: Wed Sep  8 19:41:55 2021 UTC

to:

built on: Wed Sep  8 19:41:55 2021 UTC

@levitte
Fix 'openssl speed' information printout
f85c7be 
Most of all, this reduces the following:

    built on: built on: Wed Sep  8 19:41:55 2021 UTC

to:

    built on: Wed Sep  8 19:41:55 2021 UTC
@levitte levitte added branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch approval: review pending This pull request needs review by a committer labels Sep 8, 2021
@beldmit
Copy link
Member

beldmit commented Sep 8, 2021

md-nits failure is irrelevant but need to be fixed.

beldmit
beldmit approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levitte
Copy link
Member Author

levitte commented Sep 8, 2021

md-nits failure is irrelevant but need to be fixed.

I really find those "failures" stupidly annoying... do we really have to?

@paulidale
Copy link
Contributor

paulidale commented Sep 9, 2021 •
edited

I really find those "failures" stupidly annoying... do we really have to?

I think so. I'd accept a git hook that rejected a submission with end of line white space for most files.

Fix in #16567

@t8m t8m added approval: done This pull request has the required number of approvals triaged: bug The issue/pr is/fixes a bug and removed approval: review pending This pull request needs review by a committer labels Sep 9, 2021
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Sep 10, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Sep 10, 2021
openssl-machine pushed a commit that referenced this pull request Sep 10, 2021
@levitte
Fix 'openssl speed' information printout
c1dc353 
Most of all, this reduces the following:

    built on: built on: Wed Sep  8 19:41:55 2021 UTC

to:

    built on: Wed Sep  8 19:41:55 2021 UTC

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #16563)
openssl-machine pushed a commit that referenced this pull request Sep 10, 2021
@levitte
Fix 'openssl speed' information printout
9e1b6f3 
Most of all, this reduces the following:

    built on: built on: Wed Sep  8 19:41:55 2021 UTC

to:

    built on: Wed Sep  8 19:41:55 2021 UTC

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #16563)

(cherry picked from commit c1dc353)
@levitte
Copy link
Member Author

levitte commented Sep 10, 2021

Merged

3.0:
c1dc353 Fix 'openssl speed' information printout

master:
9e1b6f3 Fix 'openssl speed' information printout

@levitte levitte closed this Sep 10, 2021
@levitte levitte deleted the fix-speed-printout-30-20210908 branch September 10, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beldmit beldmit beldmit approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@levitte @beldmit @paulidale @openssl-machine @t8m