Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rand: don't free an mis-set pointer on error #16640

Closed
wants to merge 1 commit into from
Closed

rand: don't free an mis-set pointer on error #16640

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

This is adding robustness to the code. The fix to not mis-set the pointer
is in #16636.

Fixes #16631

  • documentation is added or updated
  • tests are added or updated

@paulidale
rand: don't free an mis-set pointer on error
de228b2 
This is adding robustness to the code.  The fix to not mis-set the pointer
is in openssl#16636.

Fixes openssl#16631
@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer branch: 3.0 Merge to openssl-3.0 branch labels Sep 20, 2021
@paulidale paulidale self-assigned this Sep 20, 2021
@paulidale paulidale mentioned this pull request Sep 20, 2021
Closed
2 tasks
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Sep 20, 2021
@t8m t8m added the triaged: bug The issue/pr is/fixes a bug label Sep 21, 2021
t8m
t8m approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for both master and 3.0

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 21, 2021
beldmit
beldmit approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 22, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Sep 22, 2021
@paulidale
rand: don't free an mis-set pointer on error
caf569a 
This is adding robustness to the code.  The fix to not mis-set the pointer
is in #16636.

Fixes #16631

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #16640)
openssl-machine pushed a commit that referenced this pull request Sep 22, 2021
@paulidale
rand: don't free an mis-set pointer on error
7260376 
This is adding robustness to the code.  The fix to not mis-set the pointer
is in #16636.

Fixes #16631

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #16640)

(cherry picked from commit caf569a)
@paulidale
Copy link
Contributor Author

Merged to both, thanks for the review.

@paulidale paulidale closed this Sep 22, 2021
@paulidale paulidale deleted the fix-16331-double-free branch May 9, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@beldmit beldmit beldmit approved these changes

Assignees

@paulidale paulidale

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch severity: fips change The pull request changes FIPS provider sources triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getrandom EAGAIN is not processed correctly
4 participants
@paulidale @openssl-machine @t8m @beldmit