Fix VMS installation #16842
Closed
Fix VMS installation #16842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
added
branch: master
|
Currently a draft, until I've verified that it works as expected |
Irazen
approved these changes
Oct 15, 2021
levitte
force-pushed
the
fix-VMS-install-3.0
branch
from
1892ca8
to
0f7016d
Compare
levitte
force-pushed
the
fix-VMS-install-3.0
branch
2 times, most recently
from
c17cd8d
to
0c63363
Compare
|
I've tested this today, it seems to work like it's supposed to, so not a draft any more. I'll run a few more tests on Sunday |
levitte
added
the
approval: review pending
|
Ping! This really should end up in the upcoming release update |
The program name version info is supposed to be the major release version number. This was forgotten when the versioning scheme was changed for 3.0, so the minor release version number slipped in as well.
Configurations/descrip.mms.tmpl uses $target{pointer_size}, not
$config{pointer_size}, so the same should be used in installation
scripts, for consistency.
Also, the modules installation directory is version agnostic on other platforms, there's no real reason why it shouldn't be on VMS.
…istently It's used in Configurations/descrip.mms.tmpl, but was forgotten in the VMS installation scripts.
The logical name for the engines directory is named one way in VMS/openssl_startup.com.in, but a different name was deassigned in VMS/openssl_shutdown.com.in.
…ms.tmpl This was part of 0cbb6f6, but was incomplete in that commit.
levitte
force-pushed
the
fix-VMS-install-3.0
branch
from
0c63363
to
b7a3ca1
Compare
mattcaswell
approved these changes
Dec 13, 2021
mattcaswell
added
approval: done
t8m
approved these changes
Dec 13, 2021
levitte
added
the
severity: urgent
|
Agree urgent |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 14, 2021
The program name version info is supposed to be the major release version number. This was forgotten when the versioning scheme was changed for 3.0, so the minor release version number slipped in as well. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #16842)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 14, 2021
Configurations/descrip.mms.tmpl uses $target{pointer_size}, not
$config{pointer_size}, so the same should be used in installation
scripts, for consistency.
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #16842)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 14, 2021
Also, the modules installation directory is version agnostic on other platforms, there's no real reason why it shouldn't be on VMS. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #16842)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 14, 2021
…istently It's used in Configurations/descrip.mms.tmpl, but was forgotten in the VMS installation scripts. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #16842)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 14, 2021
The logical name for the engines directory is named one way in VMS/openssl_startup.com.in, but a different name was deassigned in VMS/openssl_shutdown.com.in. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #16842)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 14, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #16842)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 14, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #16842)
|
Pushed to openssl-3.0 and master. There was a trivial conflict in the CHANGES.md file when cherry-picking to master, which I resolve during the merge. |
openssl-machine
pushed a commit
that referenced
this pull request
Dec 14, 2021
The program name version info is supposed to be the major release version number. This was forgotten when the versioning scheme was changed for 3.0, so the minor release version number slipped in as well. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #16842) (cherry picked from commit 3c9293b)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 14, 2021
Configurations/descrip.mms.tmpl uses $target{pointer_size}, not
$config{pointer_size}, so the same should be used in installation
scripts, for consistency.
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #16842)
(cherry picked from commit e30545e)
openssl-machine
pushed a commit
that referenced
this pull request
Dec 14, 2021
The logical name for the engines directory is named one way in VMS/openssl_startup.com.in, but a different name was deassigned in VMS/openssl_shutdown.com.in. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #16842) (cherry picked from commit 73e47e3)
levitte
added a commit
to levitte/openssl
that referenced
this pull request
Dec 18, 2023
An effort was made to update the VMS installation data to align with configuration data. This touched the script templates in VMS/, but didn't update the generation of vmsconfig.pm to match... and also missed a spot. This change adds the missing updates Ref: openssl#16842 Fixes openssl#22899
levitte
added a commit
to levitte/openssl
that referenced
this pull request
Dec 20, 2023
An effort was made to update the VMS installation data to align with configuration data. This touched the script templates in VMS/, but didn't update the generation of vmsconfig.pm to match... and also missed a spot. This change adds the missing updates Ref: openssl#16842 Fixes openssl#22899
openssl-machine
pushed a commit
that referenced
this pull request
Jan 8, 2024
An effort was made to update the VMS installation data to align with configuration data. This touched the script templates in VMS/, but didn't update the generation of vmsconfig.pm to match... and also missed a spot. This change adds the missing updates Ref: #16842 Fixes #22899 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from #23081)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 8, 2024
An effort was made to update the VMS installation data to align with configuration data. This touched the script templates in VMS/, but didn't update the generation of vmsconfig.pm to match... and also missed a spot. This change adds the missing updates Ref: #16842 Fixes #22899 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from #23081) (cherry picked from commit 4058e12)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 8, 2024
An effort was made to update the VMS installation data to align with configuration data. This touched the script templates in VMS/, but didn't update the generation of vmsconfig.pm to match... and also missed a spot. This change adds the missing updates Ref: #16842 Fixes #22899 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from #23081) (cherry picked from commit 4058e12)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 8, 2024
An effort was made to update the VMS installation data to align with configuration data. This touched the script templates in VMS/, but didn't update the generation of vmsconfig.pm to match... and also missed a spot. This change adds the missing updates Ref: #16842 Fixes #22899 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from #23081) (cherry picked from commit 4058e12)
wbeck10
pushed a commit
to wbeck10/openssl
that referenced
this pull request
Jan 8, 2024
An effort was made to update the VMS installation data to align with configuration data. This touched the script templates in VMS/, but didn't update the generation of vmsconfig.pm to match... and also missed a spot. This change adds the missing updates Ref: openssl#16842 Fixes openssl#22899 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from openssl#23081) (cherry picked from commit 4058e12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix VMS installation
VMS installation scripts were forgotten in the 3.0 release, most of
them have remained as they were for 1.1.1, when the new versioning
scheme should have been reflected in these as well.
Furthermore, the IVP is amended to check the presence of the standard
OpenSSL providers.