x509: remove dead call to strlen() #16987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition `userlen == -1` isn't possible because this is already checked on line 159 above and the subsequent strlen(3) call guarantees that it's value is positive.
paulidale
added
branch: master
InfoHunter
approved these changes
Nov 8, 2021
paulidale
added
approval: done
t8m
added
the
triaged: cleanup
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
Merged, thanks for the review. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 9, 2021
The condition `userlen == -1` isn't possible because this is already checked on line 159 above and the subsequent strlen(3) call guarantees that it's value is positive. Reviewed-by: Paul Yang <kaishen.yy@antfin.com> (Merged from #16987)
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 2, 2022
The condition `userlen == -1` isn't possible because this is already checked on line 159 above and the subsequent strlen(3) call guarantees that it's value is positive. Reviewed-by: Paul Yang <kaishen.yy@antfin.com> (Merged from openssl#16987) (cherry picked from commit a18cdd2)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 9, 2022
The condition `userlen == -1` isn't possible because this is already checked on line 159 above and the subsequent strlen(3) call guarantees that it's value is positive. Reviewed-by: Paul Yang <kaishen.yy@antfin.com> (Merged from #16987) (cherry picked from commit a18cdd2) Reviewed-by: Hugo Landau <hlandau@openssl.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition
userlen == -1isn't possible because this is already checkedon line 159 above and the subsequent strlen(3) call guarantees that it's value
is positive.