Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverity: add a daily coverity build #16988

Closed
wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

The weekly build got lost when we stopped using Travis.

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added the branch: master Merge to master branch label Nov 8, 2021
@paulidale paulidale self-assigned this Nov 8, 2021
@paulidale paulidale force-pushed the static-analysis branch 6 times, most recently from 91b26c1 to 7256a9b Compare November 8, 2021 03:47
@paulidale
Copy link
Contributor Author

paulidale commented Nov 8, 2021

It isn't possible to demonstrate a successful CI run against the main repo. Secrets aren't permitted.
There is a successful build against my fork of the main repo, it has a change to the on: line however.

The secret is used in the tool download and Coverity upload steps, it is obfuscated into *** correctly. This build also kicked off a Coverity scan successfully.

The @openssl/otc should come up with a policy for merging things that cannot be properly tested via the CIs.

The weekly build got lost when we stopped using Travis.
@t-j-h t-j-h added the approval: done This pull request has the required number of approvals label Nov 8, 2021
@t8m t8m added the triaged: feature The issue/pr requests/adds a feature label Nov 8, 2021
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@paulidale
Copy link
Contributor Author

Merged, thanks for the reviews.

@paulidale paulidale closed this Nov 9, 2021
openssl-machine pushed a commit that referenced this pull request Nov 9, 2021
The weekly build got lost when we stopped using Travis.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #16988)
@paulidale paulidale deleted the static-analysis branch November 9, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants