Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove automatic RPATH #1699

Closed
wants to merge 4 commits into from
Closed

Remove automatic RPATH #1699

wants to merge 4 commits into from

Commits on Oct 12, 2016

  1. Remove automatic RPATH 

    Before OpenSSL 1.1.0, binaries were installed in a non-standard
location by default, and runpath directories were therefore added in
those binaries, to make sure the executables would be able to find the
shared libraries they were linked with.

With OpenSSL 1.1.0 and on, binaries are installed in standard
directories by default, and the addition of runpath directories is
therefore not needed any more.
    @levitte
    levitte committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    417b786 View commit details
    Browse the repository at this point in the history

  2. Remove automatic RPATH - add user rpath support 

    Make Configure recognise -rpath and -R to support user added rpaths
for OSF1 and Solaris.  For convenience, add a variable LIBRPATH in the
Unix Makefile, which the users can use as follows:

    ./config [options] -Wl,-rpath,\$(LIBRPATH)
    @levitte
    levitte committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    227b94a View commit details
    Browse the repository at this point in the history

  3. Remove automatic RPATH - adapt shlib_wrap.sh 

    Looking for something starting with '-Wl,-rpath,' isn't good enough,
as someone might give something like '-Wl,--enable-new-dtags,-rpath,/PATH'.
Looking for ',-rpath,' should be safe enough.

We could remove the preloading stuff entirely, but just in case the
user has chosen to given RPATH setting arguments at configuration,
we'd better make sure testing will still work.  Fair warning, there
are some configuration options that do not work with preloaded OpenSSL
libraries, such as the sanity checking ones.
    @levitte
    levitte committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    409f66c View commit details
    Browse the repository at this point in the history

  4. Remove automatic RPATH - Add a CHANGES entry

    @levitte
    levitte committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    65bafe4 View commit details
    Browse the repository at this point in the history