Add null digest implementation to the default provider #17016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to keep compatibility with 1.1.1. Fixes openssl#16660
t8m
added
branch: master
github-actions
bot
added
the
severity: fips change
mattcaswell
reviewed
Nov 12, 2021
| } | ||
|
|
||
| #undef PROV_FUNC_DIGEST_FINAL | ||
| #define PROV_FUNC_DIGEST_FINAL(name, dgstsize, fin) \ |
There was a problem hiding this comment.
I'm wonder why this custom version of PROV_FUNC_DIGEST_FINAL is necessary. The only difference seems to be the check outsz >= dgstsize which presumably will always be true for the NULL digest since dgstize is 0. Or perhaps this triggers compilation warnings? Is that the justification? Possibly a comment explaining that if that is the case.
There was a problem hiding this comment.
Yes, this causes compilation warnings otherwise.
mattcaswell
approved these changes
Nov 12, 2021
mattcaswell
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
rhuijben
pushed a commit
to rhuijben/openssl
that referenced
this pull request
Nov 15, 2021
This is necessary to keep compatibility with 1.1.1. Fixes #16660 Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl/openssl#17016) (cherry picked from commit bef9b48)
rhuijben
pushed a commit
to rhuijben/openssl
that referenced
this pull request
Nov 15, 2021
This is necessary to keep compatibility with 1.1.1. Fixes #16660 Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl/openssl#17016)
|
Merged to master and 3.0 branches. Thank you for the review. |
ramikhaldi
pushed a commit
to ramikhaldi/openssl
that referenced
this pull request
Nov 21, 2021
This is necessary to keep compatibility with 1.1.1. Fixes openssl#16660 Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl#17016)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to keep compatibility with 1.1.1.
Fixes #16660
Checklist