Fix Coverity 1493746: constant expression result #17034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulidale
added
branch: master
github-actions
bot
added
the
severity: fips change
If it doesn't do anything...why do we need it? |
|
It prevents a compiler warning. For compilers where sizeof(int) == sizeof(size_t), the test is real, legitimate and required. Rather than ignoring the report, I figured putting a proper check in place would prevent all future reports and warnings from our current and some future compilers. I'm fine tagging this as a false positive that is to be ignored. It will almost certainly revisit us in the future. |
t8m
approved these changes
Nov 15, 2021
t8m
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
Merged, thanks for the feedback. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 16, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #17034)
ramikhaldi
pushed a commit
to ramikhaldi/openssl
that referenced
this pull request
Nov 21, 2021
Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#17034)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning an always false expression into a real test that doesn't do anything apart from appease the compiler.