Add support for signed BIGNUMs in the OSSL_PARAM APIs #17162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
added
branch: master
|
Some discussions in #17139 should really happen here |
levitte
commented
Nov 30, 2021
levitte
changed the title
|
This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago |
t8m
added
triaged: feature
|
Needs rebase |
levitte
force-pushed
the
signed-BN-for-OSSL_PARAM
branch
from
6dbc74c
to
46c96ac
Compare
|
Rebase done |
paulidale
added
the
approval: review pending
paulidale
reviewed
Jan 13, 2022
levitte
force-pushed
the
signed-BN-for-OSSL_PARAM
branch
from
0c549ea
to
1fb24e0
Compare
|
CI? |
This depends on PR #17139 |
levitte
force-pushed
the
signed-BN-for-OSSL_PARAM
branch
from
1fb24e0
to
5fd96a4
Compare
|
#17139 has been merged, and this PR is rebased on top of that |
levitte
changed the title
github-actions
bot
added
the
severity: fips change
paulidale
reviewed
Jan 23, 2022
t-j-h
reviewed
Jan 24, 2022
paulidale
approved these changes
Jan 25, 2022
paulidale
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Jan 26, 2022
Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #17162)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 26, 2022
Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #17162)
openssl-machine
pushed a commit
that referenced
this pull request
Jan 26, 2022
Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #17162)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OSSL_PARAM APIs currently don't support negative integers larger
than what is supported by the largest integer C type. This was
knowingly left this way in OpenSSL 3.0 for release expedience.
With this change, the OSSL_PARAM API is more feature complete visavi
what is possible with the OSSL_PARAM structure.
This depends on PR #17139