Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passphrase prompt in the PVK encoder #17181

Closed
wants to merge 5 commits into from
Closed

Fix passphrase prompt in the PVK encoder #17181

wants to merge 5 commits into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Dec 2, 2021

Fixes #17054

Checklist
  • tests are added or updated

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels Dec 2, 2021
@t8m t8m mentioned this pull request Dec 2, 2021
Closed
@t-j-h t-j-h added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 2, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 3, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Dec 6, 2021
@t8m
Fix pvk encoder to properly query for the passphrase
a2ab3dc 
The passphrase callback data was not properly initialized.

Fixes #17054

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17181)

(cherry picked from commit baa88d9)
openssl-machine pushed a commit that referenced this pull request Dec 6, 2021
@t8m
PVK decoder: prompt for PVK passphrase and not PEM
06082b9 
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17181)

(cherry picked from commit 28257d6)
openssl-machine pushed a commit that referenced this pull request Dec 6, 2021
@t8m
key_to_type_specific_pem_bio_cb: Use passphrase callback from the arg…
13f0d76 
…uments

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17181)

(cherry picked from commit c22b659)
openssl-machine pushed a commit that referenced this pull request Dec 6, 2021
@t8m
test_rsa: Test for PVK format conversion
d635d74 
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17181)

(cherry picked from commit a44eb84)
openssl-machine pushed a commit that referenced this pull request Dec 6, 2021
@t8m
Fix pvk encoder to properly query for the passphrase
baa88d9 
The passphrase callback data was not properly initialized.

Fixes #17054

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17181)
openssl-machine pushed a commit that referenced this pull request Dec 6, 2021
@t8m
PVK decoder: prompt for PVK passphrase and not PEM
28257d6 
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17181)
openssl-machine pushed a commit that referenced this pull request Dec 6, 2021
@t8m
key_to_type_specific_pem_bio_cb: Use passphrase callback from the arg…
c22b659 
…uments

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17181)
openssl-machine pushed a commit that referenced this pull request Dec 6, 2021
@t8m
test_rsa: Test for PVK format conversion
a44eb84 
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17181)
@t8m
Copy link
Member Author

t8m commented Dec 6, 2021

Merged to master and 3.0 branches. Thank you for the reviews.

@t8m t8m closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@t-j-h t-j-h t-j-h approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it possible to create pvk files with OpenSSL 3.0?
5 participants
@t8m @openssl-machine @levitte @t-j-h @paulidale