Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes opensssl typos to openssl (extra "s") in documentation #17191

Closed
wants to merge 1 commit into from
Closed

changes opensssl typos to openssl (extra "s") in documentation #17191

wants to merge 1 commit into from

Conversation

samueleaton
Copy link
Contributor

Checklist
  • documentation is added or updated

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Dec 3, 2021
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Dec 3, 2021
@bernd-edlinger
Copy link
Member

nice, while you are already there, how about fixing those as well?
crypto/evp/pmeth_gn.c: * Asssigning gentmp to ctx->keygen_info is something our legacy
doc/internal/man3/ossl_method_construct.pod:for ensuring the necesssary data is made available.
doc/man3/OSSL_HTTP_REQ_CTX.pod:OSSL_HTTP_REQ_CTX_nbio_d2i() is like OSSL_HTTP_REQ_CTX_nbio() but on successs

@bernd-edlinger
Copy link
Member

and of course also:
providers/implementations/kdfs/x942kdf.c: * start of the alllocated buffer at this point.
apps/include/http_server.h: * keep_alive: grant persistent connnection

@samueleaton
Copy link
Contributor Author

@bernd-edlinger happy to make more doc fixes, but I'm not understanding the issues you are describing at those files.

@bernd-edlinger
Copy link
Member

It just appeared logical to me to look for similar typos,
and grepped for things like triple-sss and triple-nnn or triple-lll since those don't normally appear in english words.
so I'd change alllocated to allocated and connnection to connection, Asssigning to Assigning,
necesssary to necessary and successs to success.

@samueleaton
Copy link
Contributor Author

oh wow those were so subtle that i didn't even see them in your comment, thus my confusion. yes will fix.

@t8m t8m added branch: master Merge to master branch triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch labels Dec 6, 2021
paulidale
paulidale approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finds. This would be considered trivial changes I think. If you agree, could you add a line containing only CLA:trivial to the initial commit message (use git amend) or submit a CLA.

@paulidale paulidale added the approval: review pending This pull request needs review by a committer label Dec 7, 2021
@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 9, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 10, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor

Merged to both branches. Thanks for the fixes.

@paulidale paulidale closed this Dec 10, 2021
openssl-machine pushed a commit that referenced this pull request Dec 10, 2021
@samueleaton @paulidale
changes opensssl typos to openssl
44fde44 
CLA: trivial

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17191)
openssl-machine pushed a commit that referenced this pull request Dec 10, 2021
@samueleaton @paulidale
changes opensssl typos to openssl
075b1b4 
CLA: trivial

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17191)

(cherry picked from commit 44fde44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulidale paulidale paulidale approved these changes

@slontis slontis slontis approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@samueleaton @bernd-edlinger @openssl-machine @paulidale @slontis @t8m