Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APPS/cmp: Fix use of OPENSSL_NO_SOCK #17226

Closed
wants to merge 1 commit into from
Closed

APPS/cmp: Fix use of OPENSSL_NO_SOCK #17226

wants to merge 1 commit into from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented Dec 7, 2021

Options like -server, -port, and -tls_used do not make sense with no-sock.

@DDvO DDvO added approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug labels Dec 7, 2021
@DDvO
Copy link
Contributor Author

DDvO commented Dec 7, 2021 •
edited

I'm not sure if this qualifies for the openssl-3.0 branch?

@t8m t8m added the branch: master Merge to master branch label Dec 8, 2021
@t8m
Copy link
Member

t8m commented Dec 8, 2021

I'm not sure if this qualifies for the openssl-3.0 branch?

I'm not sure either. It seems to me to be a bug fix as having options that do not really work in a build is useless. So IMO it could be accepted. However it is borderline.

@t8m t8m added the branch: 3.0 Merge to openssl-3.0 branch label Dec 8, 2021
t8m
t8m approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for both master and 3.0

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: otc review pending This pull request needs review by an OTC member labels Dec 8, 2021
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 9, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@DDvO
Copy link
Contributor Author

DDvO commented Dec 9, 2021

Merged - thanks @t8m

@DDvO DDvO closed this Dec 9, 2021
openssl-machine pushed a commit that referenced this pull request Dec 9, 2021
@DDvO
APPS/cmp: Fix use of OPENSSL_NO_SOCK: options like -server do not mak…
83b424c 
…e sense with no-sock

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17226)
openssl-machine pushed a commit that referenced this pull request Dec 9, 2021
@DDvO
APPS/cmp: Fix use of OPENSSL_NO_SOCK: options like -server do not mak…
f2499f5 
…e sense with no-sock

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17226)

(cherry picked from commit 83b424c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DDvO @t8m @openssl-machine