Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSL_HTTP_proxy_connect(): Fix glitch in response HTTP header parsing #17250

Closed
wants to merge 1 commit into from
Closed

OSSL_HTTP_proxy_connect(): Fix glitch in response HTTP header parsing #17250

wants to merge 1 commit into from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented Dec 9, 2021

Fixes #17247

@DDvO DDvO added branch: master Merge to master branch approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug labels Dec 9, 2021
@DDvO DDvO mentioned this pull request Dec 9, 2021
Closed
@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: otc review pending This pull request needs review by an OTC member labels Dec 9, 2021
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Dec 11, 2021
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Dec 11, 2021
@DDvO
Copy link
Contributor Author

DDvO commented Dec 13, 2021

Merged - thanks @paulidale and @t8m.

I just wondered whether this bug fix needs to be backported to 3.0, but this is not needed, so closing.

@DDvO DDvO closed this Dec 13, 2021
openssl-machine pushed a commit that referenced this pull request Dec 13, 2021
@DDvO
OSSL_HTTP_proxy_connect(): Fix glitch in response HTTP header parsing
2490d10 
Fixes #17247

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17250)
DDvO added a commit to mpeylo/cmpossl that referenced this pull request Aug 5, 2022
@DDvO
OSSL_HTTP_proxy_connect(): Fix glitch in response HTTP header parsing
edf1d62 
Fixes openssl#17247

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#17250)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

@emwonsix emwonsix emwonsix approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

s_client -proxy option broken in master
5 participants
@DDvO @openssl-machine @t8m @paulidale @emwonsix