Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsa exp: move declarations before code #17287

Closed
wants to merge 1 commit into from
Closed

rsa exp: move declarations before code #17287

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

Fixes the oops in #17123 when code occurs before some declarations.

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels Dec 16, 2021
@paulidale paulidale self-assigned this Dec 16, 2021
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Dec 16, 2021
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 16, 2021
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 17, 2021
openssl-machine pushed a commit that referenced this pull request Dec 18, 2021
@paulidale
rsa exp: move declarations before code
2437832 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #17287)
@paulidale paulidale mentioned this pull request Dec 18, 2021
Closed
@paulidale
Copy link
Contributor Author

Merged to master, 3.0 isn't cherry picking cleanly.
#17305 is for 3.0.

@paulidale paulidale closed this Dec 18, 2021
@paulidale paulidale deleted the code-pre-decl branch December 18, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees

@paulidale paulidale

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch severity: fips change The pull request changes FIPS provider sources triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulidale @openssl-machine @t8m @mattcaswell