Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/http_client.c: fix warning of gcc-4.8.x #17308

Closed
wants to merge 1 commit into from
Closed

test/http_client.c: fix warning of gcc-4.8.x #17308

wants to merge 1 commit into from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented Dec 18, 2021

In http_test.c, simplify constant initalization of server_args struct that gcc-4.8.x warns about, reported in #16030 (review)

@DDvO DDvO added branch: master Merge to master branch approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels Dec 18, 2021
@DDvO DDvO changed the title HTTP client: fix two comilation nit/warning in test/http_client.c test/http_client.c: fix warning of gcc-4.8.x Dec 18, 2021
@DDvO DDvO mentioned this pull request Dec 18, 2021
Closed
2 tasks
@DDvO DDvO removed the branch: 3.0 Merge to openssl-3.0 branch label Dec 18, 2021
@DDvO
Copy link
Contributor Author

DDvO commented Dec 18, 2021 •
edited

The unrelated external-test-pyca (1.51.0, 3.9) failed - no clue why.

@kaduk
Copy link
Contributor

kaduk commented Dec 18, 2021

I recently saw someone run into a similar issue with pyca-cryptography and openssl still in the build tree -- IIUC the issue was trying to load the legacy provider in a situation where the config file that's suposed to load that provider into the address space waasn't in the expected location, so OSSL_PROVIDER_load(NULL, "legacy") failed.

@DDvO DDvO added the approval: done This pull request has the required number of approvals label Dec 20, 2021
@DDvO
Copy link
Contributor Author

DDvO commented Dec 20, 2021

I recently saw someone run into a similar issue with pyca-cryptography and openssl still in the build tree -- IIUC the issue was trying to load the legacy provider in a situation where the config file that's suposed to load that provider into the address space waasn't in the expected location, so OSSL_PROVIDER_load(NULL, "legacy") failed.

Thanks @kaduk for your approval and this comment confirming that this PR is independent of the failed test.
Hopefully the issue with pyca-cryptography will be solved soon such that no further PRs with suffer from this hickup (or at least its diagnostics gets improved such that the reason for and the relevance of this test failure becomes more clear).

@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Dec 20, 2021
@paulidale paulidale added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Dec 20, 2021
openssl-machine pushed a commit that referenced this pull request Dec 21, 2021
@DDvO
http_test.c: Simplify constant init of 'server_args' struct for gcc-4…
a497a90 
….8.x

Reviewed-by: Ben Kaduk <kaduk@mit.edu>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17308)
@DDvO
Copy link
Contributor Author

DDvO commented Dec 21, 2021

Merged - thanks @kaduk and @paulidale

@DDvO DDvO closed this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaduk kaduk kaduk approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DDvO @kaduk @paulidale @t8m