Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close_console: Always unlock as the lock is always held #17365

Closed
wants to merge 1 commit into from
Closed

close_console: Always unlock as the lock is always held #17365

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Dec 28, 2021

Fixes #17364

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels Dec 28, 2021
@t8m t8m mentioned this pull request Dec 28, 2021
Closed
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Dec 29, 2021
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jan 3, 2022
openssl-machine pushed a commit that referenced this pull request Jan 3, 2022
@t8m
close_console: Always unlock as the lock is always held
b247bb5 
Fixes #17364

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #17365)

(cherry picked from commit 5bea0e2)
openssl-machine pushed a commit that referenced this pull request Jan 3, 2022
@t8m
close_console: Always unlock as the lock is always held
5bea0e2 
Fixes #17364

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #17365)
@t8m t8m mentioned this pull request Jan 3, 2022
Closed
@t8m t8m removed the branch: 1.1.1 Merge to OpenSSL_1_1_1-stable branch label Jan 3, 2022
@t8m
Copy link
Member Author

t8m commented Jan 3, 2022

Merged to master and 3.0 branches. Created a separate PR for 1.1.1

@t8m t8m closed this Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential locking problem between methods open_console and lose_console
3 participants
@t8m @openssl-machine @mattcaswell