Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sm2: fix {i2d,d2i}_PublicKey EC_KEY is EVP_PKEY_SM2 #17389

Closed
wants to merge 1 commit into from
Closed

sm2: fix {i2d,d2i}_PublicKey EC_KEY is EVP_PKEY_SM2 #17389

wants to merge 1 commit into from

Conversation

zhaozg
Copy link
Contributor

@zhaozg zhaozg commented Jan 1, 2022

CLA: trivial

Checklist
  • documentation is added or updated
  • tests are added or updated

@t8m t8m added branch: 3.0 Merge to openssl-3.0 branch branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' triaged: bug The issue/pr is/fixes a bug labels Jan 3, 2022
t8m
t8m approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure is not relevant.

@t8m t8m added the approval: review pending This pull request needs review by a committer label Jan 3, 2022
paulidale
paulidale approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, trivial.

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 4, 2022
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jan 5, 2022
openssl-machine pushed a commit that referenced this pull request Jan 5, 2022
@zhaozg @t8m
sm2: fix {i2d,d2i}_PublicKey EC_KEY is EVP_PKEY_SM2
8582dcc 
CLA: trivial

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17389)
openssl-machine pushed a commit that referenced this pull request Jan 5, 2022
@zhaozg @t8m
sm2: fix {i2d,d2i}_PublicKey EC_KEY is EVP_PKEY_SM2
82df03d 
CLA: trivial

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17389)

(cherry picked from commit 8582dcc)
@t8m
Copy link
Member

t8m commented Jan 5, 2022

Merged to master and 3.0 branches. Thank you for your contribution.

@t8m t8m closed this Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch cla: trivial One of the commits is marked as 'CLA: trivial' triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhaozg @openssl-machine @t8m @paulidale