Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update troublesome copyright years of auto-generated files to 2022 #17398

Closed
wants to merge 1 commit into from
Closed

Update troublesome copyright years of auto-generated files to 2022 #17398

wants to merge 1 commit into from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented Jan 3, 2022

(Basically) same procedure as last year (#13764) or every(?) year.
This is just a quick workaround for the still unsolved New Year issue #13765.

Please approve ASAP since the issue causes needless CI failures for all new/updated PRs.

@DDvO DDvO added approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) labels Jan 3, 2022
@DDvO DDvO mentioned this pull request Jan 3, 2022
Closed
@t8m t8m added approval: done This pull request has the required number of approvals approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: otc review pending This pull request needs review by an OTC member approval: done This pull request has the required number of approvals labels Jan 3, 2022
@t8m
Copy link
Member

t8m commented Jan 3, 2022

I agree with it being urgent.

@DDvO
Copy link
Contributor Author

DDvO commented Jan 3, 2022

Thanks @t8m for the immediate treatment - merged.

openssl-machine pushed a commit that referenced this pull request Jan 3, 2022
@DDvO
Update troublesome copyright years of auto-generated files to 2022
0088ef4 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17398)
@DDvO
Copy link
Contributor Author

DDvO commented Jan 3, 2022

Ah, and the same will surely be needed for openssl-3.0 as well.
Shall I cherry-pick this there?

@t8m
Copy link
Member

t8m commented Jan 3, 2022

Ah, and the same will surely be needed for openssl-3.0 as well.
Shall I cherry-pick this there?

Would the patch be really the same there? If so, then OK.

@t8m t8m added branch: 3.0 Merge to openssl-3.0 branch branch: master Merge to master branch labels Jan 3, 2022
openssl-machine pushed a commit that referenced this pull request Jan 3, 2022
@DDvO
Update troublesome copyright years of auto-generated files to 2022
5135551 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17398)

(cherry picked from commit 0088ef4)
@DDvO
Copy link
Contributor Author

DDvO commented Jan 3, 2022

Ah, and the same will surely be needed for openssl-3.0 as well.
Shall I cherry-pick this there?

Would the patch be really the same there? If so, then OK.

It is the same because between 3.0 and the master the set of affected files did not change.
So backported/cherry-picked the workaround to 3.0.

@DDvO
Copy link
Contributor Author

DDvO commented Jan 3, 2022

Which reminds me that we might have a related issue also with 1.1.1,
but there certainly some adaptations would be needed,
so we may leave that open until someone actually hits the issue there,
or would it be better if I proactively open a PR for 1.1.1?

@DDvO DDvO mentioned this pull request Jan 3, 2022
Closed
@DDvO
Copy link
Contributor Author

DDvO commented Jan 3, 2022

I meanwhile think it's better to do the backport already now - see #17401.

@DDvO DDvO closed this Jan 3, 2022
@bernd-edlinger bernd-edlinger mentioned this pull request Jan 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DDvO @t8m