Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run TLSFuzzer tests when it is not properly set #17448

Closed
wants to merge 2 commits into from

Conversation

beldmit
Copy link
Member

@beldmit beldmit commented Jan 9, 2022

Follow-up PR for #17340

If TLSFuzzer submodule is not checked up, skip the test.

Checklist
  • documentation is added or updated
  • tests are added or updated

Copy link
Member

@bernd-edlinger bernd-edlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bernd-edlinger bernd-edlinger added approval: done This pull request has the required number of approvals branch: master Merge to master branch labels Jan 11, 2022
@beldmit
Copy link
Member Author

beldmit commented Jan 11, 2022

Don't get why automation didn't mark it as "ready to merge"

@beldmit
Copy link
Member Author

beldmit commented Jan 11, 2022

Merged. Thanks!

@beldmit beldmit closed this Jan 11, 2022
openssl-machine pushed a commit that referenced this pull request Jan 11, 2022
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17448)
@t8m t8m added the triaged: bug The issue/pr is/fixes a bug label Oct 17, 2022
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 2, 2022
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#17448)

(cherry picked from commit e5fb4b1)
openssl-machine pushed a commit that referenced this pull request Nov 9, 2022
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17448)

(cherry picked from commit e5fb4b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants