Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVP_DigestSignFinal: *siglen should not be read if sigret == NULL #17460

Closed
wants to merge 1 commit into from
Closed

EVP_DigestSignFinal: *siglen should not be read if sigret == NULL #17460

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Jan 10, 2022

This fixes small regression from #16962.

As reported by @jwalch in 182cc64#commitcomment-63342825

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels Jan 10, 2022
t8m referenced this pull request Jan 10, 2022
@paulidale
Address Coverity 1493387 Logically dead code
182cc64 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #16962)
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 11, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jan 12, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jan 12, 2022
@t8m
EVP_DigestSignFinal: *siglen should not be read if sigret == NULL
a4e0118 
This fixes small regression from #16962.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17460)
openssl-machine pushed a commit that referenced this pull request Jan 12, 2022
@t8m
EVP_DigestSignFinal: *siglen should not be read if sigret == NULL
3dcec2f 
This fixes small regression from #16962.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17460)

(cherry picked from commit a4e0118)
@t8m
Copy link
Member Author

t8m commented Jan 12, 2022

Merged to 3.0 and master branches. Thank you for the reviews.

@t8m t8m closed this Jan 12, 2022
@t8m t8m deleted the fix-16962-regression branch May 11, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@t8m @openssl-machine @mattcaswell @paulidale