Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl: TSAN fixes when TSAN requires locking #17489

Closed
wants to merge 1 commit into from
Closed

ssl: TSAN fixes when TSAN requires locking #17489

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

@paulidale paulidale commented Jan 13, 2022 •
edited

Only the final commit is relevant here, the rest are from #17479 and will disappear once this is rebased.

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels Jan 13, 2022
@paulidale paulidale self-assigned this Jan 13, 2022
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Jan 13, 2022
@paulidale
ssl: better support TSAN operations
66ac600 
For platforms that do not have native TSAN support, locking needs to be used
instead.  This adds the locking.
@paulidale
Copy link
Contributor Author

Rebased to remove the extra commits now that #17479 has been merged.

@github-actions github-actions bot removed the severity: fips change The pull request changes FIPS provider sources label Jan 13, 2022
@paulidale
Copy link
Contributor Author

@mattcaswell ??

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 18, 2022
@paulidale
Copy link
Contributor Author

Merged to 3.0 and master. Thanks for the review.

openssl-machine pushed a commit that referenced this pull request Jan 19, 2022
@paulidale
ssl: better support TSAN operations
acce055 
For platforms that do not have native TSAN support, locking needs to be used
instead.  This adds the locking.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #17489)
@paulidale paulidale closed this Jan 19, 2022
@paulidale paulidale deleted the tsan-ssl branch January 19, 2022 10:53
openssl-machine pushed a commit that referenced this pull request Jan 19, 2022
@paulidale
ssl: better support TSAN operations
078439d 
For platforms that do not have native TSAN support, locking needs to be used
instead.  This adds the locking.

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #17489)

(cherry picked from commit acce055)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees

@paulidale paulidale

Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulidale @mattcaswell