Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing cipher and digest context dup functions #17529

Closed
wants to merge 5 commits into from
Closed

Add missing cipher and digest context dup functions #17529

wants to merge 5 commits into from

Conversation

paulidale
Copy link
Contributor

Both of these have CTX_copy functions defined but no ctx_dup ones.

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: feature The issue/pr requests/adds a feature labels Jan 17, 2022
@paulidale paulidale self-assigned this Jan 17, 2022
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Jan 17, 2022
@paulidale paulidale linked an issue Jan 18, 2022 that may be closed by this pull request
EVP_XXX_dup() functions #15957
Open
t8m
t8m approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if the fixup commits are squashed when merging.

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 18, 2022
@paulidale
Copy link
Contributor Author

Merged, thanks for the reviews.

@paulidale paulidale closed this Jan 19, 2022
@paulidale paulidale deleted the ctx-copy branch January 19, 2022 10:50
openssl-machine pushed a commit that referenced this pull request Jan 19, 2022
@paulidale
fix indentation
2c9da41 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17529)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2022
@paulidale
Add context dup functions for digests and ciphers
4e62f1a 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17529)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2022
@paulidale
doc: document digest and cipher dup functions
0324ae3 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17529)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2022
@paulidale
test: add digest context dup tests
0be4b04 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17529)
openssl-machine pushed a commit that referenced this pull request Jan 19, 2022
@paulidale
test: add cipher context dup test
ed16b0f 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17529)
@slontis slontis mentioned this pull request Jul 22, 2022
Open
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 2, 2022
@paulidale @t8m
fix indentation
d31e229 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#17529)

(cherry picked from commit 2c9da41)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 2, 2022
@paulidale @t8m
Add context dup functions for digests and ciphers
91ec0cf 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#17529)

(cherry picked from commit 4e62f1a)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 2, 2022
@paulidale @t8m
doc: document digest and cipher dup functions
449e9ab 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#17529)

(cherry picked from commit 0324ae3)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 2, 2022
@paulidale @t8m
test: add digest context dup tests
486a221 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#17529)

(cherry picked from commit 0be4b04)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 2, 2022
@paulidale @t8m
test: add cipher context dup test
d77440e 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#17529)

(cherry picked from commit ed16b0f)
openssl-machine pushed a commit that referenced this pull request Nov 9, 2022
@paulidale @t8m
fix indentation
fc83bd1 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17529)

(cherry picked from commit 2c9da41)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 9, 2022
@paulidale @t8m
Add context dup functions for digests and ciphers
107b160 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17529)

(cherry picked from commit 4e62f1a)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 9, 2022
@paulidale @t8m
doc: document digest and cipher dup functions
0e1634d 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17529)

(cherry picked from commit 0324ae3)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 9, 2022
@paulidale @t8m
test: add digest context dup tests
15e6cb6 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17529)

(cherry picked from commit 0be4b04)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 9, 2022
@paulidale @t8m
test: add cipher context dup test
3fe69d9 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17529)

(cherry picked from commit ed16b0f)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

Assignees

@paulidale paulidale

Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVP_XXX_dup() functions
2 participants
@paulidale @t8m