Fix sm3ss1 translation issue in sm3-armv8.pl #17542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulidale
approved these changes
Jan 18, 2022
paulidale
added
approval: review pending
mattcaswell
approved these changes
Jan 18, 2022
t8m
approved these changes
Jan 18, 2022
t8m
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
|
Merged. Thanks for the contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Jan 20, 2022
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #17542)
t8m
pushed a commit
to t8m/openssl
that referenced
this pull request
Nov 2, 2022
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl#17542) (cherry picked from commit bca6cc5)
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Sep 18, 2023
This patch contains the following two PRs, 1. SM3 acceleration with SM3 hardware instruction on aarch64 SM3 hardware instruction is optional feature of crypto extension for aarch64. This implementation accelerates SM3 via SM3 instructions. For the platform not supporting SM3 instruction, the original C implementation still works. Thanks to AliBaba for testing and reporting the following perf numbers for Yitian710: Benchmark on T-Head Yitian-710 2.75GHz: Before: type 16 bytes 64 bytes 256 bytes 1024 bytes 8192 bytes 16384 bytes sm3 49297.82k 121062.63k 223106.05k 283371.52k 307574.10k 309400.92k After (33% - 74% faster): type 16 bytes 64 bytes 256 bytes 1024 bytes 8192 bytes 16384 bytes sm3 65640.01k 179121.79k 359854.59k 481448.96k 534055.59k 538274.47k Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl/openssl#17454) 2. Fix sm3ss1 translation issue in sm3-armv8.pl Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl/openssl#17542) reference: https://gitee.com/src-openeuler/openssl/blob/openEuler-22.03-LTS-Next/Backport-SM3-acceleration-with-SM3-hardware-instruction-on-aa.patch Signed-off-by: dumbdog <lemlinkinpark@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sm3-armv8.pl supposes to replace all series of sm3 instructions with instruction binary so that the generated .S file is able to be compiled successfully by a lower version of compiler not supporting sm3 instructions.
But sm3ss1 instruction is not replaced correctly in this file because "sm3ssl" instead of "sm3ss1" is used to do the matching in regular expression. So this fix corrects the typo sm3ssl with sm3ss1.