Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context dup functions for KDFs #17572

Closed
wants to merge 19 commits into from
Closed

Add context dup functions for KDFs #17572

wants to merge 19 commits into from

Conversation

paulidale
Copy link
Contributor

@paulidale paulidale commented Jan 24, 2022 •
edited

None of the existing KDF implementations included a context dup function. This adds them.

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch triaged: feature The issue/pr requests/adds a feature labels Jan 24, 2022
@paulidale paulidale self-assigned this Jan 24, 2022
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Jan 24, 2022
@paulidale paulidale marked this pull request as draft January 24, 2022 06:48
@paulidale paulidale marked this pull request as ready for review January 26, 2022 01:32
@paulidale paulidale added the approval: review pending This pull request needs review by a committer label Jan 26, 2022
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
prov: add a safe memdup function for context cloning
9c18257 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit 5b030ec)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
evp_test: add a ctx dup operation to the KDF tests
22b1851 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit c8adf19)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
pbkdf1: implement ctx dup operation
a3ba9b2 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit 6585d3a)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
pbkdf2: implement ctx dup operation
a58d0d8 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit 0a10f71)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
hkdf: implement ctx dup operation
f28310d 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit 95bd5ff)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
kbkdf: implement ctx dup operation
d614d64 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit d54c52c)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
krb5kdf: implement ctx dup operation
026957d 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit 4c1a841)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
scrypt: implement ctx dup operation
5713609 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit cdcdcf5)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
ssh kdf: implement ctx dup operation
ccecb43 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit 59558f9)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
ss KDF: implement ctx dup operation
1fe7c61 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit 2722eec)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
k942 kdf: implement ctx dup operation
c8da6e8 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit 769cd46)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
test: change pkey kdf dup fail test to a pkey kdf dup success test
aa9d113 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit 43332e4)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
pkcs12 kdf: implement ctx dup operation
10cf0e0 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit d3aaf4e)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
tls1 prf: implement ctx dup operation
c9a693c 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit b9d8ad3)
t8m pushed a commit to t8m/openssl that referenced this pull request Nov 9, 2022
@paulidale @t8m
indentation fix
f3670c4 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from openssl#17572)

(cherry picked from commit 1751356)
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
prov: add a safe memdup function for context cloning
a262d4f 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit 5b030ec)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
evp_test: add a ctx dup operation to the KDF tests
f46befd 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit c8adf19)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
pbkdf1: implement ctx dup operation
34d2a07 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit 6585d3a)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
pbkdf2: implement ctx dup operation
e9f0b72 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit 0a10f71)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
hkdf: implement ctx dup operation
6343c3c 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit 95bd5ff)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
kbkdf: implement ctx dup operation
a0a589b 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit d54c52c)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
krb5kdf: implement ctx dup operation
cb94904 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit 4c1a841)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
scrypt: implement ctx dup operation
e85d09d 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit cdcdcf5)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
ssh kdf: implement ctx dup operation
99a414d 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit 59558f9)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
ss KDF: implement ctx dup operation
ab09d2d 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit 2722eec)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
k942 kdf: implement ctx dup operation
0f52297 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit 769cd46)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
test: change pkey kdf dup fail test to a pkey kdf dup success test
6e6024c 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit 43332e4)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
pkcs12 kdf: implement ctx dup operation
0ca770e 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit d3aaf4e)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
tls1 prf: implement ctx dup operation
dbe35ee 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit b9d8ad3)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
openssl-machine pushed a commit that referenced this pull request Nov 11, 2022
@paulidale @t8m
indentation fix
70df6ca 
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #17572)

(cherry picked from commit 1751356)
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-j-h t-j-h t-j-h left review comments

@slontis slontis slontis approved these changes

Assignees

@paulidale paulidale

Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulidale @openssl-machine @t-j-h @slontis