Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the comment on ssl3_write_pending() #17611

Closed
wants to merge 1 commit into from
Closed

Update the comment on ssl3_write_pending() #17611

wants to merge 1 commit into from

Conversation

yangyangtiantianlonglong
Copy link
Contributor

@yangyangtiantianlonglong yangyangtiantianlonglong commented Jan 29, 2022 •
edited

The struct s->s3 has been modified.
Check if there is a SSL3_BUFFER left, ssl3_write_pending() should be called.

Checklist
  • documentation is added or updated

@yangyangtiantianlonglong
Update the comment on ssl3_write_pending()
67b7225 
The struct s->s3 has been modified.
@mattcaswell mattcaswell added approval: review pending This pull request needs review by a committer branch: master Merge to master branch labels Jan 31, 2022
@t8m t8m added the triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly label Jan 31, 2022
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jan 31, 2022
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Feb 1, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Feb 1, 2022
@t8m
Copy link
Member

t8m commented Feb 1, 2022

Merged to the master branch. Thank you for your contribution.

@t8m t8m closed this Feb 1, 2022
openssl-machine pushed a commit that referenced this pull request Feb 1, 2022
@yangyangtiantianlonglong @t8m
Update the comment on ssl3_write_pending()
7c7c356 
The struct s->s3 has been modified.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #17611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yangyangtiantianlonglong @openssl-machine @t8m @mattcaswell @paulidale