On shared library names #1767
Closed
On shared library names #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is overdue since the addition of the unified build system
|
@kaduk, I'd be very pleased if you'd read through the added notes to see if they are satisfactory. |
kaduk
approved these changes
Oct 22, 2016
There was a problem hiding this comment.
If I had written something, I probably would have included the strings "libcrypto" and "libssl" in CHANGES, but I don't have a good sense for whether there are people who are familiar with the windows names but not the Unix names.
Regardless, this is nice to have, even as-is -- thanks!
| @@ -947,6 +947,31 @@ | |||
| where OpenSSL does not know how to build shared libraries the "no-shared" | |||
| option will be forced and only static libraries will be created. | |||
|
|
|||
| Shared libraries are named a little different on different platforms. | |||
There was a problem hiding this comment.
I might use "differently" ... but I might not.
richsalz
approved these changes
Oct 22, 2016
|
@richsalz, I forgot to lable the intended branches. Now done, are you still fine with it? |
|
Yes. |
levitte
added a commit
that referenced
this pull request
Oct 25, 2016
This is overdue since the addition of the unified build system Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1767)
levitte
added a commit
that referenced
this pull request
Oct 25, 2016
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #1767)
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kaduk informed me that there was no information on the new DLL names on Windows... and except for the git log, he's absolutely correct. This adds the information in
INSTALLand adds a not to this effect in the entry inCHANGESthat announces the unified build, 'cause that's where this should have been notified from the start.