Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -quiet option to pkcs7 for -print_certs #17708

Closed
wants to merge 4 commits into from
Closed

Add -quiet option to pkcs7 for -print_certs #17708

wants to merge 4 commits into from

Conversation

rferrandop
Copy link
Contributor

I opened this PR for the CLA be effective. (Closed the previous one #17693)

Fixes #17089

Added a new -quiet option to show a "clean" output and be useful for future use with other flags.

Checklist
  • documentation is added or updated

@t8m t8m added branch: master Merge to master branch triaged: feature The issue/pr requests/adds a feature labels Feb 15, 2022
t8m
t8m requested changes Feb 15, 2022
View reviewed changes
doc/man1/openssl-pkcs7.pod.in Outdated Show resolved Hide resolved
apps/pkcs7.c Outdated Show resolved Hide resolved
@rferrandop rferrandop requested a review from t8m February 15, 2022 15:42
@t8m t8m added the approval: review pending This pull request needs review by a committer label Feb 15, 2022
@rferrandop
Copy link
Contributor Author

Hi again @t8m , I added the test

@rferrandop rferrandop closed this Feb 15, 2022
@rferrandop rferrandop reopened this Feb 15, 2022
@rferrandop rferrandop requested a review from t8m February 15, 2022 17:31
paulidale
paulidale approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A fairly trivial grammar suggestion. Good once fixed.

apps/pkcs7.c Outdated Show resolved Hide resolved
@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 22, 2022
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Feb 23, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Feb 23, 2022
@paulidale
Copy link
Contributor

Merged, thanks for this.

@paulidale paulidale closed this Feb 24, 2022
openssl-machine pushed a commit that referenced this pull request Feb 24, 2022
@rferrandop @paulidale
Add -quiet option to pkcs7 for -print_certs
632e8be 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17708)
@rferrandop rferrandop deleted the pkcs7-quiet-version branch May 31, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Clean' PKCS7 print_certs without the subject= & issuer= text lines
4 participants
@rferrandop @openssl-machine @paulidale @t8m