Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix few doc #17721

Closed
wants to merge 2 commits into from
Closed

Fix few doc #17721

wants to merge 2 commits into from

Conversation

yangyangtiantianlonglong
Copy link
Contributor

@yangyangtiantianlonglong yangyangtiantianlonglong commented Feb 17, 2022 •
edited

Checklist
  • documentation is added or updated

t8m
t8m reviewed Feb 17, 2022
View reviewed changes
ssl/record/rec_layer_s3.c Outdated Show resolved Hide resolved
@t8m t8m added branch: master Merge to master branch triaged: documentation The issue/pr deals with documentation (errors) labels Feb 17, 2022
@yangyangtiantianlonglong yangyangtiantianlonglong changed the title Fix few doc and comment Fix few doc Feb 18, 2022
@t8m t8m added the approval: review pending This pull request needs review by a committer label Feb 18, 2022
@t-j-h t-j-h added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Feb 18, 2022
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Feb 19, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Feb 19, 2022
openssl-machine pushed a commit that referenced this pull request Feb 20, 2022
@yangyangtiantianlonglong @mspncp
doc: Update "SSL/TLS" old documentation description in openssl.pod
5272fdc 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #17721)
openssl-machine pushed a commit that referenced this pull request Feb 20, 2022
@yangyangtiantianlonglong @mspncp
doc: Refactored the example in crypto.pod
4a4f446 
Added return value and error code in the sample

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #17721)
@mspncp
Copy link
Contributor

mspncp commented Feb 20, 2022

Merged to master, thank you for your contribution!

  • 4a4f446 doc: Refactored the example in crypto.pod
  • 5272fdc doc: Update "SSL/TLS" old documentation description in openssl.pod

@mspncp mspncp closed this Feb 20, 2022
openssl-machine pushed a commit that referenced this pull request Feb 20, 2022
@yangyangtiantianlonglong @mspncp
doc: Refactored the example in crypto.pod
18e046c 
Added return value and error code in the sample

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from #17721)

(cherry picked from commit 4a4f446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@t-j-h t-j-h t-j-h approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yangyangtiantianlonglong @openssl-machine @mspncp @t8m @t-j-h