Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSL_PARAM_get_*_ptr: Drop errors from ptr/string mismatch #17997

Closed
wants to merge 1 commit into from
Closed

OSSL_PARAM_get_*_ptr: Drop errors from ptr/string mismatch #17997

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Mar 30, 2022

Those errors started to appear when decoding as we use get_ptr functions there on string parameters.

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug labels Mar 30, 2022
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Mar 30, 2022
@paulidale paulidale removed the approval: otc review pending This pull request needs review by an OTC member label Mar 30, 2022
@t8m
Copy link
Member Author

t8m commented Apr 1, 2022

ping for second review

beldmit
beldmit approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 1, 2022
@openssl-machine openssl-machine removed the approval: done This pull request has the required number of approvals label Apr 2, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@openssl-machine openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Apr 2, 2022
@paulidale
Copy link
Contributor

Merged to master. I'd be fine with this going to 3.0 since it is a bug fix. Anyone else agree?

@paulidale paulidale closed this Apr 3, 2022
openssl-machine pushed a commit that referenced this pull request Apr 3, 2022
@t8m @paulidale
OSSL_PARAM_get_*_ptr: Drop errors from ptr/string mismatch
327a720 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17997)
@slontis slontis mentioned this pull request Jul 22, 2022
Open
t8m added a commit to t8m/openssl that referenced this pull request Nov 14, 2022
@t8m
OSSL_PARAM_get_*_ptr: Drop errors from ptr/string mismatch
470833f 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl#17997)

(cherry picked from commit 327a720)
openssl-machine pushed a commit that referenced this pull request Nov 21, 2022
@t8m
OSSL_PARAM_get_*_ptr: Drop errors from ptr/string mismatch
a48081a 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #17997)

(cherry picked from commit 327a720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beldmit beldmit beldmit approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@t8m @openssl-machine @paulidale @beldmit