Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdf: avoid NULL dereference on malloc failure in sshkdf #18011

Closed
wants to merge 1 commit into from
Closed

kdf: avoid NULL dereference on malloc failure in sshkdf #18011

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

Fixes #18009

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels Mar 31, 2022
@paulidale paulidale self-assigned this Mar 31, 2022
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Mar 31, 2022
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Apr 1, 2022
@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 7, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 8, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor Author

Merged, thanks for the reviews.

@paulidale paulidale closed this Apr 10, 2022
openssl-machine pushed a commit that referenced this pull request Apr 10, 2022
@paulidale
kdf: avoid NULL dereference on malloc failure in sshkdf
7d486b2 
Fixes #18009

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #18011)

(cherry picked from commit 148176c)
openssl-machine pushed a commit that referenced this pull request Apr 10, 2022
@paulidale
kdf: avoid NULL dereference on malloc failure in sshkdf
148176c 
Fixes #18009

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #18011)
@paulidale paulidale deleted the fix-18009 branch May 6, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@slontis slontis slontis approved these changes

Assignees

@paulidale paulidale

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch severity: fips change The pull request changes FIPS provider sources triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NULL pointer dereference in kdf_sshkdf_new if allocation fails
4 participants
@paulidale @openssl-machine @t8m @slontis