Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Coverity 1503314 unchecked return value #18013

Closed
wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

Hoping that the cast to void appeases Coverity.

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member branch: 3.0 Merge to openssl-3.0 branch labels Mar 31, 2022
@paulidale paulidale self-assigned this Mar 31, 2022
@t8m t8m added triaged: bug The issue/pr is/fixes a bug and removed approval: otc review pending This pull request needs review by an OTC member labels Apr 1, 2022
@t8m
Copy link
Member

t8m commented Apr 1, 2022

I probably would not bother backporting to 3.0 as we do not try to make coverity clean on 3.0.

@paulidale paulidale removed the branch: 3.0 Merge to openssl-3.0 branch label Apr 1, 2022
@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@paulidale
Copy link
Contributor Author

Ping for review #2?

@DDvO DDvO added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 3, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 4, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor Author

Merged to master.

@paulidale paulidale closed this May 4, 2022
openssl-machine pushed a commit that referenced this pull request May 4, 2022
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18013)
@paulidale paulidale deleted the coverity-1503314 branch May 6, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants