Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sm2: Allow setting 0 length SM2 dist ID param #18052

Closed
wants to merge 2 commits into from
Closed

sm2: Allow setting 0 length SM2 dist ID param #18052

wants to merge 2 commits into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Apr 6, 2022

Fixes #18022

Checklist
  • tests are added or updated

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels Apr 6, 2022
@t8m t8m mentioned this pull request Apr 6, 2022
Closed
@paulidale paulidale removed the approval: otc review pending This pull request needs review by an OTC member label Apr 7, 2022
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 7, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 8, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member Author

t8m commented Apr 11, 2022

Merged to master and 3.0 branches. Thank you for the reviews.

@t8m t8m closed this Apr 11, 2022
openssl-machine pushed a commit that referenced this pull request Apr 11, 2022
@t8m
sm2: Allow setting 0 length SM2 dist ID param
444513d 
Fixes #18022

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #18052)

(cherry picked from commit 2904d0a)
openssl-machine pushed a commit that referenced this pull request Apr 11, 2022
@t8m
Add test for resetting SM2 dist ID
b6f262c 
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #18052)

(cherry picked from commit 707d4e0)
openssl-machine pushed a commit that referenced this pull request Apr 11, 2022
@t8m
sm2: Allow setting 0 length SM2 dist ID param
2904d0a 
Fixes #18022

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #18052)
openssl-machine pushed a commit that referenced this pull request Apr 11, 2022
@t8m
Add test for resetting SM2 dist ID
707d4e0 
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #18052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

@InfoHunter InfoHunter Awaiting requested review from InfoHunter

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression issue for use id_a:empty string and id_a_size:0 to sm2 sign in OpenSSL 3.0.2
4 participants
@t8m @openssl-machine @mattcaswell @paulidale