Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unix Makefile: Some sed implementation truncate long lines. Use perl instead #1813

Closed
wants to merge 1 commit into from
Closed

Unix Makefile: Some sed implementation truncate long lines. Use perl instead #1813

wants to merge 1 commit into from

Conversation

levitte
Copy link
Member

@levitte levitte commented Oct 31, 2016 •
edited

Checklist
  • CLA is signed
Description of change

instead.

Fixes #1781

@levitte levitte added branch: master Merge to master branch 1.1.0 labels Oct 31, 2016
@t-j-h
Copy link
Member

t-j-h commented Oct 31, 2016

Is that placing a dependency on having perl to run a build now that wasn't present before?

@levitte
Copy link
Member Author

levitte commented Oct 31, 2016

Is that placing a dependency on having perl to run a build now that wasn't present before?

Nope. We're using perl all over the place.

@richsalz
Copy link
Contributor

yeah,. perl is a requirement. +1

@levitte
Copy link
Member Author

levitte commented Oct 31, 2016

... and @teschulz confirmed the fix is working as well. Perfect.

levitte added a commit that referenced this pull request Oct 31, 2016
@levitte
Unix Makefile: Some sed implementation truncate long lines. Use perl …
ebca796 
…instead.

Fixes #1781

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #1813)
@levitte
Copy link
Member Author

levitte commented Oct 31, 2016

Merged!

@levitte levitte closed this Oct 31, 2016
levitte added a commit that referenced this pull request Oct 31, 2016
@levitte
Unix Makefile: Some sed implementation truncate long lines. Use perl …
936503c 
…instead.

Fixes #1781

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from #1813)
(cherry picked from commit ebca796)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richsalz richsalz richsalz approved these changes

Assignees
No one assigned
Labels
branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build problem on Solaris 8
3 participants
@levitte @t-j-h @richsalz