siphash: Fail finalization on uninitialized siphash context #18142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8m
added
branch: master
Also fully duplicate the context on dup
t8m
force-pushed
the
siphash-fail-uninited
branch
from
01edfb8
to
1ee46eb
Compare
t8m
added
approval: review pending
InfoHunter
reviewed
Apr 24, 2022
t8m
added
the
severity: regression
|
ping for reviews |
paulidale
approved these changes
Apr 25, 2022
paulidale
removed
the
approval: otc review pending
mattcaswell
approved these changes
Apr 26, 2022
mattcaswell
added
approval: done
openssl-machine
removed
the
approval: done
|
This pull request is ready to merge |
openssl-machine
added
the
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Apr 27, 2022
Also fully duplicate the context on dup Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #18142)
openssl-machine
pushed a commit
that referenced
this pull request
Apr 27, 2022
Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #18142)
|
Merged to master and 3.0 branches. Thank you for your reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also properly update sipcopy when setting the size and fully duplicate the context on dup.
Fixes #18140
Checklist