Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new release commit review requirement bypass #18155

Closed
wants to merge 1 commit into from
Closed

Add support for new release commit review requirement bypass #18155

wants to merge 1 commit into from

Conversation

hlandau
Copy link
Member

@hlandau hlandau commented Apr 22, 2022

No description provided.

@hlandau hlandau added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: feature The issue/pr requests/adds a feature branch: 3.0 Merge to openssl-3.0 branch labels Apr 22, 2022
@hlandau hlandau self-assigned this Apr 22, 2022
@mattcaswell mattcaswell removed the approval: otc review pending This pull request needs review by an OTC member label Apr 22, 2022
@t8m t8m added approval: done This pull request has the required number of approvals triaged: bug The issue/pr is/fixes a bug and removed approval: review pending This pull request needs review by a committer triaged: feature The issue/pr requests/adds a feature labels Apr 22, 2022
@t8m
Copy link
Member

t8m commented Apr 22, 2022

I am labeling it as bug as this is a part of a fix for a bug in our release process.

@levitte
Copy link
Member

levitte commented Apr 23, 2022

I've learned a bash feature with this...

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@t8m t8m added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 25, 2022
@t8m
Copy link
Member

t8m commented Apr 25, 2022

Merged to master and 3.0 branches. Thank you.

@t8m t8m closed this Apr 25, 2022
openssl-machine pushed a commit that referenced this pull request Apr 25, 2022
@hlandau @t8m
Add support for new release commit review requirement bypass
af5b3af 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18155)

(cherry picked from commit a625354)
openssl-machine pushed a commit that referenced this pull request Apr 25, 2022
@hlandau @t8m
Add support for new release commit review requirement bypass
a625354 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #18155)
@levitte
Copy link
Member

levitte commented Apr 26, 2022

When your work with openssl/tools#115 is merged, this probably needs to be undone in favor of adding --release to all the addrev commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees

@hlandau hlandau

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hlandau @t8m @levitte @openssl-machine @mattcaswell