Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix_dh_paramgen_type: Avoid crash with invalid paramgen type #18202

Closed
wants to merge 1 commit into from
Closed

fix_dh_paramgen_type: Avoid crash with invalid paramgen type #18202

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Apr 28, 2022

This fixes a segfault on openssl genpkey -genparam -algorithm DH -pkeyopt dh_paramgen_type:4

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels Apr 28, 2022
beldmit
beldmit approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit removed the approval: otc review pending This pull request needs review by an OTC member label Apr 28, 2022
@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 29, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 30, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member Author

t8m commented May 2, 2022

Merged to master and 3.0 branches. Thank you for your reviews.

@t8m t8m closed this May 2, 2022
openssl-machine pushed a commit that referenced this pull request May 2, 2022
@t8m
fix_dh_paramgen_type: Avoid crash with invalid paramgen type
bffdd57 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18202)

(cherry picked from commit 359dad5)
openssl-machine pushed a commit that referenced this pull request May 2, 2022
@t8m
fix_dh_paramgen_type: Avoid crash with invalid paramgen type
359dad5 
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beldmit beldmit beldmit approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@t8m @openssl-machine @beldmit @paulidale