Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a testcase for OSSL_PROVIDER_unload() being fully effective #18254

Closed
wants to merge 1 commit into from
Closed

Add a testcase for OSSL_PROVIDER_unload() being fully effective #18254

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented May 5, 2022

This accompanies #18151 so it should be merged to 3.0 as well.

Checklist
  • tests are added or updated

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch labels May 5, 2022
@t8m t8m requested a review from levitte May 5, 2022 12:47
@t8m
Copy link
Member Author

t8m commented May 5, 2022

I've verified the test fails if the last two commits from #18151 aren't present.

@mattcaswell mattcaswell removed the approval: otc review pending This pull request needs review by an OTC member label May 5, 2022
@t8m
Copy link
Member Author

t8m commented May 5, 2022

Close/reopen to rerun the tests as #18151 is now merged

@t8m t8m closed this May 5, 2022
@t8m t8m reopened this May 5, 2022
@levitte
Copy link
Member

levitte commented May 5, 2022

Looks good. I'll wait to see how it fares

@levitte levitte added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 6, 2022
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 7, 2022
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request May 9, 2022
@t8m @paulidale
Add a testcase for OSSL_PROVIDER_unload() being fully effective
4b4d0de 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18254)
openssl-machine pushed a commit that referenced this pull request May 9, 2022
@t8m @paulidale
Add a testcase for OSSL_PROVIDER_unload() being fully effective
20a0a3e 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #18254)

(cherry picked from commit 4b4d0de)
@paulidale
Copy link
Contributor

Merged to both.

@paulidale paulidale closed this May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@t8m @levitte @openssl-machine @paulidale @mattcaswell